Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VTPM container to access TPM devices via tpms group #4010

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

shjala
Copy link
Member

@shjala shjala commented Jun 26, 2024

Allows the VTPM container to access the TPM devices via the tpms group set in the additionalGids in the build.yml file.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milan-zededa
Copy link
Contributor

Smoke tests can be fixed by rebase on the latest master.

@milan-zededa
Copy link
Contributor

Re-running Virtualization test suite because the success is surprising - want to know if it is reproducible or if it was just a lucky accident.

@eriknordmark
Copy link
Contributor

Seems like the smoketests are failing on re-runs
https://github.com/lf-edge/eve/actions/runs/9691051715/job/26750839250?pr=4010

@milan-zededa
Copy link
Contributor

Seems like the smoketests are failing on re-runs https://github.com/lf-edge/eve/actions/runs/9691051715/job/26750839250?pr=4010

Smoke tests can be fixed by rebase on the latest master.

Allows the VTPM container to access the TPM devices via the tpms group
set in the additionalGids in the build.yml file.

Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run again

@eriknordmark eriknordmark merged commit bc7ec4b into lf-edge:master Jun 27, 2024
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants