Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump uevent #4031

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Bump uevent #4031

merged 1 commit into from
Jul 1, 2024

Conversation

christoph-zededa
Copy link
Contributor

@christoph-zededa christoph-zededa commented Jul 1, 2024 •
edited
Loading

include this fix: eshard/uevent@d8d2be2

@christoph-zededa
go.mod: bump eshard/uevent
28bfb62 
this fixes an issue in case read (on the netlink socket) returns
-1 in case of an error

go's bufio library always expects greater-or-equal 0

Signed-off-by: Christoph Ostarek <christoph@zededa.com>
eriknordmark
eriknordmark approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did some test fail due to this uevent issue?

@milan-zededa
Copy link
Contributor

LGTM

Did some test fail due to this uevent issue?

Yes, one of the smoke tests caught panic:

2024-07-01 08:55:03.514|null|pillar|| panic: bufio: reader returned negative count from Read
2024-07-01 08:55:03.514|null|pillar|| null
2024-07-01 08:55:03.515|null|pillar|| goroutine 489 [running]:
2024-07-01 08:55:03.519|null|pillar|| bufio.(*Reader).fill(0xc000ef9f18)
2024-07-01 08:55:03.521|null|pillar||   /usr/lib/go/src/bufio/bufio.go:108 +0x19b
2024-07-01 08:55:03.523|null|pillar|| bufio.(*Reader).ReadSlice(0xc000ef9f18, 0x20?)
2024-07-01 08:55:03.525|null|pillar||   /usr/lib/go/src/bufio/bufio.go:372 +0x2f
2024-07-01 08:55:03.528|null|pillar|| bufio.(*Reader).collectFragments(0x5?, 0xe0?)
2024-07-01 08:55:03.530|null|pillar||   /usr/lib/go/src/bufio/bufio.go:447 +0x74
2024-07-01 08:55:03.532|null|pillar|| bufio.(*Reader).ReadString(0x1000?, 0x0?)
2024-07-01 08:55:03.537|null|pillar||   /usr/lib/go/src/bufio/bufio.go:494 +0x2b
2024-07-01 08:55:03.537|null|pillar|| github.com/eshard/uevent.(*Decoder).next(...)
2024-07-01 08:55:03.538|null|pillar||   /pillar/vendor/github.com/eshard/uevent/decoder.go:81
2024-07-01 08:55:03.538|null|pillar|| github.com/eshard/uevent.(*Decoder).Decode(0xc000ef9d90)
2024-07-01 08:55:03.539|null|pillar||   /pillar/vendor/github.com/eshard/uevent/decoder.go:42 +0x67
2024-07-01 08:55:03.539|null|pillar|| github.com/lf-edge/eve/pkg/pillar/cmd/usbmanager.(*usbmanagerController).listenUSBPorts.func2()
2024-07-01 08:55:03.540|null|pillar||   /pillar/cmd/usbmanager/usbevent.go:46 +0x387
2024-07-01 08:55:03.541|null|pillar|| created by github.com/lf-edge/eve/pkg/pillar/cmd/usbmanager.(*usbmanagerController).listenUSBPorts
2024-07-01 08:55:03.542|null|pillar||   /pillar/cmd/usbmanager/usbevent.go:34 +0x1cf

@eriknordmark eriknordmark merged commit 68378c9 into lf-edge:master Jul 1, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknordmark eriknordmark eriknordmark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christoph-zededa @milan-zededa @eriknordmark