Run Collect-info through Edgeview

[naiming-zededa]

there are a number of request to have edgeview support for collectinfo,
this patch has the list of implementation:

• Add the implementation on running collect-info through Edgeview
• Egeview is mostly only with read permission access to device filesystems
  and it does not want to import all the pkgs and replicate the collect-info.sh
  operations and maintain compatibility of two sets of the collect-info
• this implementation has a protocol to setup a request for debug container
  to start run 'collect-info.sh', and remove the request file after it is done;
  Edgeview then uses existing copy file protocol to transfer the collect-info
  tarball file back to user's laptop; then Edgeview put another request for
  debug container to remove the created tarball file in /persist
• debug container has added a background task to monitor the requests
• Since collect-info is mostly live info, there is no need to get all the newlogs,
  only fetch the newlogs of the past 10 days.
• Introduced debug/debug-services.sh around the exiting sshd and the new edgeview-collectinfo.sh

[OhmSpectator]

Commit messages, pleeeease 😭😭😭

[naiming-zededa]

Commit messages, pleeeease 😭😭😭

hmm, i thought the one before were commit messages, but I added something before the list, is that what you meant?

[OhmSpectator]

hmm, i thought the one before were commit messages, but I added something before the list, is that what you meant?

No, I mean the messages that you add to any commit when creating it...
Like here: e74fae7
Or here: caad6b5

Without proper commit messages, it's hard to understand the changes made when looking through the history or git blame. It's nice you've added a PR description here on GitHub, but it will be lost after the PR is merged: it will be impossible to see it from an IDE or the command line...

[naiming-zededa]

@OhmSpectator added in the commit. to see if this is good. thanks.

[eriknordmark]

Note that the pathname for the eve-info files changed in #4125 so they are in the /persist/eve-info/ directory instead of just in /persist/

So presumably you need to add that eve-info component to the pathnames you use here.

[naiming-zededa]

Note that the pathname for the eve-info files changed in #4125 so they are in the /persist/eve-info/ directory instead of just in /persist/

So presumably you need to add that eve-info component to the pathnames you use here.

missed that. will change.

[naiming-zededa]

Changed to reflect the new /persist/eve-info/ as the base. I removed the 'mkdir -p "/persist/$INFO_DIR_SUFFIX"' in the collect-info.sh, since this created directory is not used, and never removed after.
I have tested this new change for both manual run and through the edgeview.

[eriknordmark]

Changed to reflect the new /persist/eve-info/ as the base. I removed the 'mkdir -p "/persist/$INFO_DIR_SUFFIX"' in the collect-info.sh, since this created directory is not used, and never removed after. I have tested this new change for both manual run and through the edgeview.

Odd, because I had to add that mkdir to make the tar command not fail when I just did a 'eve enter debug' followed by collect-info.sh.
But if you tested that, then there must have been some fluke when I ran it.

[naiming-zededa]

fixed a yetus complaining

[eriknordmark]

Do we have any automatic tests of edgeview? And how hard would it be to create some basic one to just check that it is functional?

[naiming-zededa]

Do we have any automatic tests of edgeview? And how hard would it be to create some basic one to just check that it is functional?

Currently I don't have this infra. We need to create a task/jira item o this.

[eriknordmark]

LGTM

[eriknordmark]

@naiming-zededa the regression/eden tests passed, but there might be some open comments/issues on the PR. Can you check if those are taken care of to satisfaction?

[naiming-zededa]

@naiming-zededa the regression/eden tests passed, but there might be some open comments/issues on the PR. Can you check if those are taken care of to satisfaction?

@eriknordmark I went through them, they should all be resolved.