[12.0-stable] IoBundle.KeepInHost should not forbid assignment #4110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeepInHost
is used to keep unassigned devices visible to the host, i.e., not reserved for future PCI passthrough. However, once a device withKeepInHost=true
is selected for assignment to an application, the assignment takes precedence overKeepInHost
. OnlyIsPort=true
devices are forbidden from assignment.After a recent change, everything is kept in the host until assignment, and therefore we may consider removing the
KeepInHost
flag. See commit: aad213fBut here we only fix a bug introduced in the commit referenced above. Specifically,
KeepInHost
was misunderstood and used to forbid (or more precisely skip) device assignment. This makes it impossible, for example, to assign WiFi adapters or cellular modems.(cherry picked from commit 5b9cbd9)