-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NI with multiple ports #4123
Add support for NI with multiple ports #4123
Conversation
6a9eb20
to
0a110da
Compare
0a110da
to
e9e644a
Compare
e9e644a
to
7ddd245
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - kicking off tests in parallel with review discussion.
FWIW I see "Uplink" and "UplinkProber" in pkg/pillar/docs/zedrouter.md and in pkg/pillar/types/domainmgrtypes.go. Don't know if/when you want to change those.
Signed-off-by: Milan Lenco <milan@zededa.com>
7ddd245
to
fc90f2d
Compare
79bbc68
to
994cc58
Compare
There was an unused |
4228967
to
a13dd81
Compare
This commit implements support for Local NI with multiple ports attached. API changes with detailed description can be found here: lf-edge/eve-api#53 In summary, network instance can be now configured with "shared" port label, potentially matching multiple device ports. The NI routing table will contain routes from all the selected ports. Shared labels can be also used to restrict port-forwarding to a subset of NI ports and to create multipath static routes (routes with multiple possible next-hops). For every multipath route, zedrouter will use recently added portprober to select the best port at a given time (based on the connectivity status, cost, etc.) and also to failover to another port when the currently used port looses connectivity. Signed-off-by: Milan Lenco <milan@zededa.com>
uplinkprober was superseded by the newly introduced portprober Signed-off-by: Milan Lenco <milan@zededa.com>
a13dd81
to
0a450aa
Compare
This commit implements support for Local NI with multiple ports attached.
API changes with detailed description can be found here:
lf-edge/eve-api#53
This is a continuation to PRs:
#4098
#4113
(next PR will bring documentation updates)
In summary, network instance can be now configured with "shared" port
label, potentially matching multiple device ports. The NI routing table
will contain routes from all the selected ports.
Shared labels can be also used to restrict port-forwarding to a subset
of NI ports and to create multipath static routes (routes with multiple
possible next-hops). For every multipath route, zedrouter will use
recently added portprober to select the best port at a given time (based
on the connectivity status, cost, etc.) and also to failover to another
port when the currently used port looses connectivity.
Eden-SDN example for NI with multiple ports: lf-edge/eden#1008