Update edge-view to work with the latest pillar #4139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Lenco <milan@zededa.com>
christoph-zededa
approved these changes
Aug 9, 2024
|
I have no idea why Yetus keeps failing. The output has much less files than usually. |
pkg/edgeview/src/network.go
Outdated
| dstNet := route.DstNetwork.String() | ||
| if route.GatewayApp != emptyUUID { | ||
| fmt.Printf(" - route dst: %s, gw app: %s\n", | ||
| route.DstNetwork, route.GatewayApp) |
There was a problem hiding this comment.
can we also add the 'Gateway' in the display of the routes in both if and else cases?
After introducing support for Local NI with multiple ports, few fields in the NetworkInstance status and metrics have changed. Also, VolumeRefConfig no longer has the RefCount field. Edge-view needs to be updated to reflect all these changes. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
edgeview-update
branch
from
654c5ed
to
a24bd64
Compare
github-actions
bot
requested review from
christoph-zededa,
eriknordmark and
naiming-zededa
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4139 +/- ##
==========================================
+ Coverage 17.51% 19.69% +2.17%
==========================================
Files 3 8 +5
Lines 805 2600 +1795
==========================================
+ Hits 141 512 +371
- Misses 629 1985 +1356
- Partials 35 103 +68 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing support for Local NI with multiple ports, few fields in the
NetworkInstanceStatusandNetworkInstanceMetricshave changed.Also,
VolumeRefConfigno longer has theRefCountfield.Edge-view needs to be updated to reflect all these changes.