Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue in collect-info.sh, need to mkdir /persist/eve-info #4147

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

naiming-zededa
Copy link
Contributor

@naiming-zededa naiming-zededa commented Aug 14, 2024

  • fix the problem of collect-info, the /persist/eve-info dir may not exist.
    Last time i removed the code 'mkdir -p "/persist/$INFO_DIR_SUFFIX',
    even though the /persist/eve-info/eve-info-v28-(some timestamp) directory
    is not needed, but this 'persist/eve-info' directory is required. I missed
    that in the last change on the collect-info.sh.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OhmSpectator
Copy link
Member

Commit message, please.
Also, we have ti change the script version at the top of the script every time we change it.

 Last change to collect-info missed to create the /persist/eve-info
 directory which is required.

Signed-off-by: Naiming Shen <naiming@zededa.com>
@naiming-zededa
Copy link
Contributor Author

Commit message, please. Also, we have ti change the script version at the top of the script every time we change it.

done. thanks.

@milan-zededa milan-zededa merged commit 52c2294 into lf-edge:master Aug 15, 2024
13 of 14 checks passed
@naiming-zededa naiming-zededa deleted the naiming-collectinfo-fix branch August 15, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants