Add kernel tag to ROOTFS_VERSION if KERNEL_TAG is provided #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building EVE with custome kernel i.e. make KERNEL_TAG=... rootfs version doesn’t take it into account and it may be really confusing especially when building from a tag. E.g. when building from 12.0.3-lts tag EVE version will be set to 12.0.3-lts and so - it looks like an official image but it is not - if the image is uploaded to cloud the official image with the same tag cannot be uploaded anymore Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
rouming
approved these changes
Aug 19, 2024
|
so the longest could try is |
deitch
reviewed
Aug 27, 2024
| @@ -107,6 +107,10 @@ endif | |||
| # set this to the current tag only if we are building from a tag | |||
| ROOTFS_VERSION:=$(if $(findstring snapshot,$(REPO_TAG)),$(EVE_SNAPSHOT_VERSION)-$(REPO_BRANCH)-$(REPO_SHA)$(REPO_DIRTY_TAG)$(DEV_TAG),$(REPO_TAG)) | |||
|
|
|||
| #if KERNEL_TAG is set, append it to the ROOTFS_VERSION but replace docker.io/lfedge/eve-kernel:eve-kernel- part with k- | |||
| SHORT_KERNEL_TAG=$(subst docker.io/lfedge/eve-kernel:eve-kernel-,k-,$(KERNEL_TAG)) | |||
| ROOTFS_VERSION:=$(if $(SHORT_KERNEL_TAG),$(ROOTFS_VERSION)-$(SHORT_KERNEL_TAG),$(ROOTFS_VERSION)) | |||
There was a problem hiding this comment.
So if KERNEL_TAG is unset, then ROOTFS_VERSION is unchanged? I guess this makes sense. Can we document these expected behaviours somewhere (other than reading the Makefile or its comments)? Don't we have a doc somewhere that describes "this is what the version string will be"?
OhmSpectator
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Looks good as soon as we are sure we do not forget to change here, when change branch name here:
Line 63 in cfe8513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building EVE with custome kernel i.e. make KERNEL_TAG=... rootfs version doesn’t take it into account and it may be really confusing especially when building from a tag. E.g. when building from 12.0.3-lts tag EVE version will be set to 12.0.3-lts and so
QUESTION: the only concern I have is a length of version string on cloud side. Is there any limit?