add PROGRAM parameter to eve-enter-container #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script eve-enter-container calls internally nsenter, which Defaults to calling $(SHELL) if no PROGRAM parameter is provided. And since the shim VM is built from alpine image, the default shell is /bin/ash. So unless the container running in the shim VM is also based on alpine, it won't have /bin/ash and the script will fail. This commit adds a PROGRAM parameter to the script, so that the user can specify the shell (or another program) to be used when entering the container. If the parameter is not provided, the default is /bin/sh. Signed-off-by: Paul Gaiduk <paulg@zededa.com>
europaul
requested review from
OhmSpectator,
rene and
eriknordmark
as code owners
rouming
approved these changes
Aug 21, 2024
milan-zededa
approved these changes
Aug 21, 2024
shjala
approved these changes
Aug 22, 2024
rucoder
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script eve-enter-container calls internally nsenter, which defaults to calling $(SHELL) if no PROGRAM parameter is provided. And since the shim VM is built from alpine image, the default shell is /bin/ash. So unless the container running in the shim VM is also based on alpine, it won't have /bin/ash and the script will fail.
This commit adds a PROGRAM parameter to the script, so that the user can specify the shell (or another program) to be used when entering the container. If the parameter is not provided, the default is /bin/sh.