pillar: containerd: Do not add hooks when no interfaces are configured #4174
Conversation
The hooks for veth.sh and dhcpcd scripts don't need to be added to OCI spec when no network interfaces are configured for the container. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
There was a problem hiding this comment.
@rene, so, we skip setting the DHCP client for the domain because we do not support updating the list of interfaces in runtime, right? Once the domain is started, we never change the list of network interfaces, yep?
I'm also curious: how did you get the idea of this fix?
Anyway, looks fine.
Correct @OhmSpectator , the issue arose when I tried to deploy a native container without any network interface attached/configured to it. The Edge App was a NVIDIA CUDA container from dockerhub. |
|
I guess this change should not affect any tests (do we have anything for apps without network interfaces at all?), but I have seen some of them red several times... And I'm not sure how to interpret it. Restarting again... |
The hooks for veth.sh and dhcpcd scripts don't need to be added to OCI spec when no network interfaces are configured for the container.
This will be required for bare-metal container Edge Applications.