-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dom0-ztools: rootfs: Enable Container Device Interface #4182
Conversation
This commit introduces the following changes: - Enables CDI plugin in order to allow native containers to access devices specified by CDI spec. - Adds a default loopback network configuration otherwise the plugin will throw an error during initialization. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but have to test it somehow.
@OhmSpectator , at this point nothing changes in the behavior since pillar doesn't support CDI (I will introduce it in another PR soon), we are just enabling this plugin in containerd.... but of course, let's run all the tests.... |
I mean, some manual test that shows that the plugin works correctly after this setup. We will definitely not see it in the current test results. I mean something like |
@OhmSpectator , this commit is part of my work to support bare metal containers with GPU access on ARM, it was tested by deploying NVIDIA CUDA containers that uses the CDI plugin, you can find a release candidate branch here: https://github.com/rene/eve/tree/jetson-nv-POC-rc1 I've started to push these commits upstream, so there is more to come soon.... |
Ok, so we can just trus you it work as expected =) |
Enable CDI plugin in order to allow native containers to access devices specified by CDI spec.
Add a default loopback network configuration otherwise the plugin will throw an error during initialization.