Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dom0-ztools: rootfs: Enable Container Device Interface #4182

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

rene
Copy link
Contributor

@rene rene commented Aug 29, 2024

  • Enable CDI plugin in order to allow native containers to access devices specified by CDI spec.

  • Add a default loopback network configuration otherwise the plugin will throw an error during initialization.

This commit introduces the following changes:

- Enables CDI plugin in order to allow native containers to access
  devices specified by CDI spec.

- Adds a default loopback network configuration otherwise the plugin will
  throw an error during initialization.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but have to test it somehow.

@rene
Copy link
Contributor Author

rene commented Aug 29, 2024

@OhmSpectator , at this point nothing changes in the behavior since pillar doesn't support CDI (I will introduce it in another PR soon), we are just enabling this plugin in containerd.... but of course, let's run all the tests....

@OhmSpectator
Copy link
Member

OhmSpectator commented Aug 29, 2024

@OhmSpectator , at this point nothing changes in the behavior since pillar doesn't support CDI (I will introduce it in another PR soon), we are just enabling this plugin in containerd.... but of course, let's run all the tests....

I mean, some manual test that shows that the plugin works correctly after this setup. We will definitely not see it in the current test results. I mean something like ctr plugins ls | grep cri and some manual usage of the CNI config...

@rene
Copy link
Contributor Author

rene commented Aug 29, 2024

@OhmSpectator , at this point nothing changes in the behavior since pillar doesn't support CDI (I will introduce it in another PR soon), we are just enabling this plugin in containerd.... but of course, let's run all the tests....

I mean, some manual test that shows that the plugin works correctly after this setup. We will definitely not see it in the current test results. I mean something like ctr plugins ls | grep cri and some manual usage of the CNI config...

@OhmSpectator , this commit is part of my work to support bare metal containers with GPU access on ARM, it was tested by deploying NVIDIA CUDA containers that uses the CDI plugin, you can find a release candidate branch here: https://github.com/rene/eve/tree/jetson-nv-POC-rc1

I've started to push these commits upstream, so there is more to come soon....

@OhmSpectator
Copy link
Member

@OhmSpectator , at this point nothing changes in the behavior since pillar doesn't support CDI (I will introduce it in another PR soon), we are just enabling this plugin in containerd.... but of course, let's run all the tests....

I mean, some manual test that shows that the plugin works correctly after this setup. We will definitely not see it in the current test results. I mean something like ctr plugins ls | grep cri and some manual usage of the CNI config...

@OhmSpectator , this commit is part of my work to support bare metal containers with GPU access on ARM, it was tested by deploying NVIDIA CUDA containers that uses the CDI plugin, you can find a release candidate branch here: https://github.com/rene/eve/tree/jetson-nv-POC-rc1

I've started to push these commits upstream, so there is more to come soon....

Ok, so we can just trus you it work as expected =)

@OhmSpectator OhmSpectator merged commit 80611a1 into lf-edge:master Aug 29, 2024
36 of 37 checks passed
@rene rene deleted the enable-cdi branch October 11, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants