Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eden.yml to refer to the correct output for run_id #4195

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

yash-zededa
Copy link
Collaborator

I've updated the test_suite_pr job to use the correct output for the run ID, which Eden needs to download the artifacts.

Updated the trigger_pr job to use the correct output for the run id.
This is required for eden to download the artefacts.

Signed-off-by: yash-zededa <yash@zededa.com>
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test it?

@OhmSpectator
Copy link
Member

OhmSpectator commented Sep 1, 2024

Run RESPONSE=$(curl -s -L "https://api.github.com/repos/lf-edge/eve/actions/workflows/build.yml/runs?head_sha=16beb27ce90add0ae416fc5ff85e34bee70cf8e0&status=success" \
No successful runs found

=(

@eriknordmark
Copy link
Contributor

We don't and can't run the workflows when the workflow files change.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.69%. Comparing base (695652b) to head (16beb27).
Report is 52 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4195   +/-   ##
=======================================
  Coverage   19.69%   19.69%           
=======================================
  Files           8        8           
  Lines        2600     2600           
=======================================
  Hits          512      512           
  Misses       1985     1985           
  Partials      103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it

@eriknordmark eriknordmark merged commit 61205f3 into lf-edge:master Sep 1, 2024
31 of 32 checks passed
@yash-zededa
Copy link
Collaborator Author

@OhmSpectator Not easily, I would say :).

For No successful runs found

The error is expected and can be ignored. For GHA to pick up changes in eden.yml, they need to be merged into the base branch. The eden.yml file is just there to trigger the test with the eden version.

I can see the run_id in output now so should be fixed.

@yash-zededa
Copy link
Collaborator Author

We don't and can't run the workflows when the workflow files change.

According to the GitHub documentation, there is an option to run workflows from a forked repository, but this depends on the settings at the organization level. I assume that workflows from forked repositories should not be executed, which seems prudent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants