pillar/agentlog: Improve debug information in PSI-collector test. #4199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use assert.Truef to provide a detailed error message on failure. Without the message, the error was unclear as it just indicated the boolean expression evaluated to false. Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
christoph-zededa
approved these changes
Sep 3, 2024
|
I've just noticed that we skip a lot of Go tests in the GitHub pipeline. Including the agentlog ones. |
|
Upd. I'm stupid; I look at the wrong line. The test is running and it's fine. |
|
@milan-zededa, @rene, could someone please take a look? It's straightforward and only affects one test. |
milan-zededa
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
assert.Truefto provide a detailed error message on failure. Without the message, the error was unclear as it just indicated the boolean expression evaluated to false.