Fix TPM_TOOL_LIB path in verifytpm.sh #4200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f9f0f53 change the lib location from /usr/local/lib to /usr/lib, but the path in verifytpm.sh was not updated. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
|
Do you have a (n eden) test to catch such errors? Basic tool start, I expected? |
OhmSpectator
approved these changes
Sep 3, 2024
not at the moment, this runs as part of verification image, so maybe we should have a test for whole verification process and check for expected output. I will talk to Ioannis to get his opinion. |
|
But now you are sure it works as expected, and we can merge? =) |
yes, I just found it because I was testing the script :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f9f0f53 change the lib location from
/usr/local/libto/usr/lib, but the path inverifytpm.shwas not updated.