Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Add yetus template to mini-yetus.sh #4214

Merged
merged 1 commit into from
Sep 5, 2024
Merged

tools: Add yetus template to mini-yetus.sh #4214

merged 1 commit into from
Sep 5, 2024

Conversation

rene
Copy link
Contributor

@rene rene commented Sep 5, 2024

Add the template "yetus.XXXXXXXXXX" to mktemp command on mini-yetus.sh script so it makes easier to users to find and access the output directory.

The output will be stored always at /tmp/yetus.* directory:

Running mini-yetus
./tools/mini-yetus.sh   
[+] Running mini-yetus
[+] No source branch specified. Using the main branch: master
[+] No destination branch specified. Using the current branch: improve-mini-yetus
[+] Running yetus on the changes...
[+] Results stored in /tmp/yetus.BAzEReo7uA/yetus-output

@rene
tools: Add yetus template to mini-yetus.sh
49b65ab 
Add the template "yetus.XXXXXXXXXX" to mktemp command on mini-yetus.sh
script so it makes easier to users to find and access the output
directory.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
@rene rene requested a review from deitch as a code owner September 5, 2024 09:45
@rene rene requested review from shjala and removed request for deitch September 5, 2024 09:46
OhmSpectator
OhmSpectator approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind, let it be.
Although, I still think catting output of results-full as the pe-last command of the target will be perfect. First - show the results, and then - print where to get more details.

@OhmSpectator
Copy link
Member

I've cancelled the Eden tests workflow to not waste runners' resources, as the PR does not affect any related functionality.

@OhmSpectator OhmSpectator merged commit 2d59af3 into lf-edge:master Sep 5, 2024
27 of 39 checks passed
@rene rene deleted the improve-mini-yetus branch September 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OhmSpectator OhmSpectator OhmSpectator approved these changes

@shjala shjala Awaiting requested review from shjala

@deitch deitch Awaiting requested review from deitch deitch is a code owner

@eriknordmark eriknordmark Awaiting requested review from eriknordmark

@jsfakian jsfakian Awaiting requested review from jsfakian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rene @OhmSpectator