bpftrace-compiler: add run-via-edgeview #4230
Conversation
christoph-zededa
force-pushed
the
http_debug_add_bpftrace_edgeview
branch
from
65cb674
to
9e22b23
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
christoph-zededa
force-pushed
the
http_debug_add_bpftrace_edgeview
branch
from
9e22b23
to
9784851
Compare
| } | ||
|
|
||
| func (er edgeviewRun) runEdgeview(edgeviewParam string, matchOutput string) (string, error) { | ||
| cmd := exec.Command("bash", er.path, edgeviewParam) |
There was a problem hiding this comment.
As far as I can recall, 'sh' is the default interpreter for the edge-view scripts. We can either set it here, or just run the script directly as it already contains the shebang line.
There was a problem hiding this comment.
I cannot run it directly because when I download it, the +x is not set.
Does $((9001 + $multi)) work in sh?
There was a problem hiding this comment.
Nope, sh does not know it. A good catch for @naiming-zededa. Yep then setting bash is more than justified.
christoph-zededa
force-pushed
the
http_debug_add_bpftrace_edgeview
branch
5 times, most recently
from
72c30c6
to
7dce673
Compare
|
@christoph-zededa, please ping me when you think all comments are addressed. |
I think I addressed everything, @OhmSpectator ping. |
christoph-zededa
force-pushed
the
http_debug_add_bpftrace_edgeview
branch
from
7dce673
to
b9853f6
Compare
In more RL like scenarios, it is neither possible to reach EVE via ssh nor via direct network access. For these cases edgeview was developed. This new feature leverages edgeview to run bpftrace scripts in more tough environments. Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
http_debug_add_bpftrace_edgeview
branch
from
b9853f6
to
c2fb731
Compare
|
@christoph-zededa, do you think merging now is okay without waiting for all the test runs? I don't see this PR should affect any functionality checked by these tests... |
I am okay with it, but we're also not in such a hurry not being able to wait for it ... |
Just not to waste the runners' time. |
In more RL like scenarios, it is neither possible to reach EVE via ssh nor via direct network access. For these cases edgeview was developed.
This new feature leverages edgeview to run bpftrace scripts in more tough environments.