pillar: containerd: Create a pipe for container's stdin #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the device /dev/null is used as the standard input for a container task. However, any process reading from /dev/null will always get 0 bytes as the result, which makes interactive containers, e.g., those that runs a shell as the entrypoint (and expects data on the standard input), to exit right after starting. In order to keep the container task blocked (in these situations), a valid standard input device must be provided. This commit creates a fake stdin that reads from an unpopulated pipe so it blocks the reader process. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
rene
requested review from
christoph-zededa
and removed request for
deitch and
rouming
OhmSpectator
approved these changes
Sep 11, 2024
|
It looks fine; I just want to see the Eden tests run. |
OhmSpectator
approved these changes
Sep 11, 2024
deitch
approved these changes
Sep 11, 2024
|
All green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the device /dev/null is used as the standard input for a container task. However, any process reading from /dev/null will always get 0 bytes as the result, which makes interactive containers, e.g., those that runs a shell as the entrypoint (and expects data on the standard input), to exit right after starting. In order to keep the container task blocked (in these situations), a valid standard input device must be provided. This commit creates a fake stdin that reads from an unpopulated pipe so it blocks the reader process.
This issue is not observed on standard containers because qemu's process doesn't expect any inputs on stdin. It only affects native containers.