Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RS485 mode for ttyXRUSB2/3 on kontron devices #4235

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

rucoder
Copy link
Contributor

@rucoder rucoder commented Sep 11, 2024

On Kontron devices 402/403/202 set ports 2 and 3 to RS485 Half-duplaex mode

This PR depends on lf-edge/eve-kernel#131

@rucoder rucoder requested a review from rene as a code owner September 11, 2024 09:57
@rucoder rucoder marked this pull request as draft September 11, 2024 09:57
@rucoder rucoder added the stable Should be backported to stable release(s) label Sep 11, 2024
smbios -t 1 -s 5 --set smb_product
# switch ttyXRUSB2/3 to RS485 Half-Duplex mode
if regexp -- "Agora Gateway" "$smb_product"; then
set_global hv_platform_tweaks "$hv_platform_tweaks xr_usb_serial_common.mode=2h,3h"
Copy link
Contributor

@rene rene Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be dom0_platform_tweaks since you are applying to Linux kernel....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rene yes, I fixed that already

@github-actions github-actions bot requested a review from rene September 11, 2024 12:18
@rucoder rucoder marked this pull request as ready for review September 11, 2024 12:32
smbios -t 1 -s 5 --set smb_product
# switch ttyXRUSB2/3 to RS485 Half-Duplex mode
if regexp -- "Agora Gateway" "$smb_product"; then
set_global dom0_platform_tweaks "$hv_platform_tweaks xr_usb_serial_common.mode=2h,3h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$hv_platform_tweaks xr_usb_seri... -> $dom0_platform_tweaks xr_usb_seri...

On Kontron devices 402/403/202 set ports 2 and 3 to RS485 Half-duplaex mode

Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
Copy link
Member

@OhmSpectator OhmSpectator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Do we have other dependencies, or is it ready to be merged?

@OhmSpectator OhmSpectator merged commit 43d4521 into lf-edge:master Sep 12, 2024
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable Should be backported to stable release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants