vTPM : fix arm issue by selecting correct dev name based on arch #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shjala
force-pushed
the
vtpm_arm_fix
branch
from
199110c
to
c4523eb
Compare
shjala
changed the title
rene
reviewed
Sep 13, 2024
shjala
force-pushed
the
vtpm_arm_fix
branch
from
c4523eb
to
be35031
Compare
The vTPM device name is different on ARM and x86. This patch fixes the the issue by selecting the correct device name based on the architecture. Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
shjala
force-pushed
the
vtpm_arm_fix
branch
from
be35031
to
9fe5015
Compare
OhmSpectator
approved these changes
Sep 13, 2024
|
By the way, do we have a test that could detect the error? |
rene
approved these changes
Sep 13, 2024
If we had eden arm runners, yes, the vTPM test would have failed. |
Talked to @uncleDecart , unfortunately currently we don't have ARM host runners performing Eden tests.... 😢 |
So, we still do not have access to the GitHub ARM runners? https://github.blog/news-insights/product-news/arm64-on-github-actions-powering-faster-more-efficient-build-systems/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vTPM device name is different on ARM and x86. This patch fixes the the issue by selecting the correct device name based on the architecture.
Thanks to @rene for bringing it to my attention.