Fix bridge IP source after NI modification #4258
Conversation
There is a small bug in the master recently introduced, where the address source of the reported bridge IP changes from AddressSourceEVEInternal to AddressSourceUndefined when NI config is modified in any way (note that IP source is reported only internally between microservices, not to the controller). While the reported source of the bridge IP is not important at all, we should still fix it to avoid any confusion. Signed-off-by: Milan Lenco <milan@zededa.com>
|
How will it affect the backports of the original PR into the stable branches? Will you include the fix on top of the original commit, or will you change the commits? If the latest, could you please mention it in the commit messages, |
I mentioned it in the PR description. Not sure if I want to link github PRs from the commit message. |
Sorrry, I overlooked it. I mean, it would be nice to reflect in the commit message of the cherry-picked commit the difference with the original commit. But without it is also fine. |
Right now it is used only internally by LinuxCollector, but I added this to NetworkInstanceStatus for troubleshooting purposes. |
There is a small bug in the master recently introduced, where the address source of the reported bridge IP changes from
AddressSourceEVEInternaltoAddressSourceUndefinedwhen NI config is modified in any way (note that IP source is reported only internally between microservices, not to the controller).While the reported source of the bridge IP is not important at all, we should still fix it to avoid any confusion.
Please note that this is already fixed in the backport PRs #4257 and #4256