Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Backport "Add Support for Persistent OVMF Settings in Pillar" #4262

Conversation

OhmSpectator
Copy link
Member

@OhmSpectator OhmSpectator commented Sep 16, 2024

This PR is a testing backport of #4261 into 9.4

TODO:

  • Check the eve-uefi image hash used in 9.4
  • Take the latest version of the commits from the original PR

This commit copies OVMF_VARS.fd into the pillar container by adding it
to /usr/lib/xen/boot/ovmf_vars.bin. It is important that the file is
available in the pillar container because Pillar will create per-domain
copies of it stored in /persist, which are then accessible to the
xen-tools container. This sets the groundwork for enabling virtual
machines to save and retain UEFI settings across reboots by using
per-domain NVRAM files.

Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
@OhmSpectator
Copy link
Member Author

Did we have only the DCO check in the pipeline in 9.4? oO

@OhmSpectator OhmSpectator marked this pull request as ready for review September 16, 2024 22:35
@OhmSpectator OhmSpectator marked this pull request as draft September 16, 2024 22:36
Introduce support for managing per-domain OVMF_VARS.fd files, which are
essential for maintaining persistent UEFI settings for FML guests. It
adds functionality to prepare and clean up individual OVMF settings
files stored in the persist directory, ensuring that each virtual
machine has its own dedicated NVRAM file. The VM configuration
structures are updated to reference the bootloader settings file,
enabling the creation of unique UEFI variable stores for each domain.

Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
@OhmSpectator OhmSpectator force-pushed the backport-9.4/persist-ovmf-settings branch from aa01843 to 5f04405 Compare September 16, 2024 22:41
@rouming
Copy link
Contributor

rouming commented Sep 17, 2024

FYI: If this is the customer ask to have a backport to a branch which is end of support for quite a while, please be aware, that this branch does not include many other fixes due its EOS status

@OhmSpectator
Copy link
Member Author

FYI: If this is the customer ask to have a backport to a branch which is end of support for quite a while, please be aware, that this branch does not include many other fixes due its EOS status

Yeah, sure, we remember it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants