Fix interactive shell called from installer script #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boot option "pause before install" will pause the installation process only after wiping disks (when required), so move the pause to an earlier stage, before any destructive action to storage devices is performed. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
The installer script runs within a onboot container, with output/input not redirected to the current tty console. When a pause is required by the user (before or after the installation process), the shell called within the install script will not work. Forcing input/output to /dev/console fixes the problem. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
OhmSpectator
approved these changes
Sep 26, 2024
Yes, tested with QEMU for amd64 and arm64. |
deitch
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One fix and one small improvement in the installer script:
Forces shell to run interactively when required
The installer script runs within a onboot container, with output/input not redirected to the current tty console. When a pause is required by the user (before or after the installation process), the shell called within the install script will not work. Forcing input/output to /dev/console fixes the problem.
Move "pause before install" to early stage
The boot option "pause before install" will pause the installation process only after wiping disks (when required), so move the pause to an earlier stage, before any destructive action to storage devices is performed.