Fix deadlock in Go tests when Debug Server startup fails. #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `startIntegratedPSICollectorAPI`, if the server does not start within 10 seconds, the function returns an error without unlocking `psiServerMutex`. This oversight leads to a deadlock in subsequent tests that attempt to acquire the same mutex. This commit adds `psiServerMutex.Unlock()` before returning the error to ensure that the mutex is properly released even when the server fails to start. Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
christoph-zededa
approved these changes
Oct 1, 2024
rouming
approved these changes
Oct 1, 2024
OhmSpectator
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
startIntegratedPSICollectorAPI, if the server does not start within 10 seconds, the function returns an error without unlockingpsiServerMutex. This oversight leads to a deadlock in subsequent tests that attempt to acquire the same mutex.This commit adds
psiServerMutex.Unlock()before returning the error to ensure that the mutex is properly released even when the server fails to start.Needs to be backported to 13.4-stable (which didn't exist when this PR was merged).