CoordinateFilter: Support multiple CoordinateSequence dimensions #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface of CoordinateFilter is changed so that a filter should support operations on CoordinateXY* rather than Coordinate*. By default, higher-dimension coordinates will default to base-class implementations (e.g., a CoordinateXYZM will be processed as a CoordinateXY if no implementation is available for Coordiante or CoordinateXYZM.) To avoid the case where the filter implementation does not need to consider Z or M but must preserve them (e.g., repeated point removal), the CoordinateInspector and CoordinateMutator base classes are provided. These allow a filter class to inherit from the base using CRTP and provide a template for the filter method rather than an implementation for each coordinate type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface of CoordinateFilter is changed so that a filter should support operations on CoordinateXY* rather than Coordinate*. By default, higher-dimension coordinates will default to base-class implementations (e.g., a CoordinateXYZM will be processed as a CoordinateXY if no implementation is available for Coordiante or CoordinateXYZM.)
To avoid the case where the filter implementation does not need to consider Z or M but must preserve them (e.g., repeated point removal), the CoordinateInspector and CoordinateMutator base classes are provided. These allow a filter class to inherit from the base using CRTP and provide a template for the filter method rather than an implementation for each coordinate type.