Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode record-store keys in pubsub #17

Merged
merged 1 commit into from
Nov 16, 2018
Merged

encode record-store keys in pubsub #17

merged 1 commit into from
Nov 16, 2018

Conversation

Stebalien
Copy link
Member

Instead of using bare keys (binary), use /record/base64url(key). This:

  1. Pubsub keys must be UTF-8. Record-store keys definitely are not.
  2. The prefix may help with validators in the future (namespace everything).

See: ipfs/interop#39

@Stebalien
encode record-store keys in pubsub
87ee770 
Instead of using bare keys (binary), use `/record/base64url(key)`. This:

1. Pubsub keys must be UTF-8. Record-store keys definitely are not.
2. The prefix may help with validators in the future (namespace *everything*).

See: ipfs/interop#39
@ghost ghost assigned Stebalien Nov 15, 2018
@ghost ghost added the status/in-progress In progress label Nov 15, 2018
@Stebalien Stebalien mentioned this pull request Nov 15, 2018
Merged
2 tasks
magik6k
magik6k approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be breaking change for some people, but given that it's an experimental feature on top of another experimental feature, it's probably ok.

vyzo
vyzo approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a big fat warning of breakage when this gets merged in ipfs.

vasco-santos
vasco-santos approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Will do the same in js side

@vasco-santos vasco-santos mentioned this pull request Nov 16, 2018
Merged
@Stebalien Stebalien merged commit 3af4f46 into master Nov 16, 2018
@Stebalien Stebalien deleted the fix/encoding branch November 16, 2018 17:52
@ghost ghost removed the status/in-progress In progress label Nov 16, 2018
@vasco-santos vasco-santos mentioned this pull request Nov 22, 2018
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@magik6k magik6k magik6k approved these changes

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stebalien @vyzo @magik6k @vasco-santos