Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): removing dependency on libp2p-lookup #5610

Merged
merged 7 commits into from
Oct 4, 2024
Merged

fix(server): removing dependency on libp2p-lookup #5610

merged 7 commits into from
Oct 4, 2024

Conversation

guillaumemichel
Copy link
Contributor

@guillaumemichel guillaumemichel commented Sep 25, 2024 •
edited
Loading

Description

Remove dependency on libp2p-lookup which is no longer maintained, and makes checks fail.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@guillaumemichel guillaumemichel changed the title removing dependency on libp2p-lookup fix(server): removing dependency on libp2p-lookup Sep 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 26, 2024

This pull request has merge conflicts. Could you please resolve them @guillaumemichel? 🙏

jxs
jxs approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Gui!

@jxs jxs added the send-it label Oct 4, 2024
@mergify mergify bot merged commit 93ad28c into master Oct 4, 2024
69 checks passed
@mergify mergify bot deleted the remove-libp2p-lookup branch October 4, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillaumemichel @jxs