fix(websocket): don't dial /dnsaddr addresses
#5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Returns `Error::InvalidMultiaddr` when `parse_ws_dial_addr` is called with `/dnsaddr`. As per its specification, `/dnsaddr` domains are not meant to be directly dialed, instead it should be appended with `_dnsaddr.` and used for DNS lookups afterwards ## Notes & open questions * Is it okay to return an error, or if it's a `/dnsaddr` should I perform a DNS lookup and resolve that DNS afterwards? * If so, how should I handle that case where DNS lookup returns multiple addresses? ## Change checklist - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [x] I have added tests that prove my fix is effective or that my feature works - [ ] A changelog entry has been made in the appropriate crates
Co-authored-by: Darius Clark <dariusc93@users.noreply.github.com>
|
websocket-websys needs this change too. |
I see, will update there as well |
|
Hello I just opened #5619 because I want to dial Would it make sense to simply support DNS multiaddr resolution in the browser? |
|
Also #5531 could enable this? |
|
@DougAnderson444 As described in #5601, this PR removes an incorrect handling of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Returns
Error::InvalidMultiaddrwhenparse_ws_dial_addris called with/dnsaddr.As per its specification,
/dnsaddrdomains are not meant to be directly dialed, instead it should be appended with_dnsaddr.and used for DNS lookups afterwardsRelated: #5529
Fixes: #5601
Notes & open questions
/dnsaddr?Change checklist