Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update igd-next to 0.15.1 #5625

Merged
merged 2 commits into from
Oct 8, 2024
Merged

chore: update igd-next to 0.15.1 #5625

merged 2 commits into from
Oct 8, 2024

Conversation

dariusc93
Copy link
Member

Description

Resolves #5506.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@dariusc93
Copy link
Member Author

@mickvandijke does this resolve your issue?

jxs
jxs approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Darius!

@jxs jxs marked this pull request as ready for review October 8, 2024 14:15
@jxs jxs added the send-it label Oct 8, 2024
@mergify mergify bot merged commit 9a45db3 into libp2p:master Oct 8, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upnp: Gateway does not support UPnP (but it does)
2 participants
@dariusc93 @jxs