Symfony 4.1 compatibility #193
Conversation
|
Related issue: #188 |
|
thx .. can you look into the test failure? |
|
hurray! |
| $twigFilesystemLoaderDefinition->setClass($container->getParameter('liip_theme.filesystem_loader.class')); | ||
| $twigFilesystemLoaderDefinition->setArguments(array( |
There was a problem hiding this comment.
I am not totally sure, but is it possible that this call makes the bundle fail on Symfony 2.8.46? I receive an error like this:
Unable to find template "SuluWebsiteBundle:Analytics:website.html.twig|default".
But when i comment this call out, everything works again... Can somebody confirm? Should there be a check for the symfony version? Or does LiipThemeBundle starting from version 1.6 not support symfony 2 anymore?
There was a problem hiding this comment.
well we still support Symfony 2 if it doesn't cause major problems ..
I was expecting the test suite to catch any such issues, but maybe it does not ..
So if you can come up with a simple enough fix to make it work again I am happy to merge it.
| $twigFilesystemLoaderDefinition->setClass($container->getParameter('liip_theme.filesystem_loader.class')); | ||
| $twigFilesystemLoaderDefinition->setArguments(array( | ||
| $container->getDefinition('liip_theme.templating_locator'), | ||
| $container->getDefinition('templating.filename_parser') |
There was a problem hiding this comment.
That line seems to be the root cause of the issue :-) It generally works with Symfony 2.8 (that's probably why the test didn't fail), but the colon notation (Bundle:folder:view.html.twig) does not work anymore... Does anything speak against using the TemplateNameParser here?
There was a problem hiding this comment.
We should probably continue the discussion in #194.
Hi there,
on Symfony 4.1 there is some errors with this bundle:
getDefinitionbyfindDefinitionto fix error: You have requested a non-existent service "twig.loader.filesystem"templating.filename_parserto fix error: You have requested a non-existent service "templating.filename_parser".