Request to be blocked all the time

[lw33]

Hi
When making an HTTP call on the server side, I noticed that if the health check fails, the request gets blocked and doesn't time out, leading to what appears to be a deadlock.
Below is my test code. When I make a request to http://localhost:8080/test1 in the browser, the request doesn't return and doesn't timeout. I don't know if this is a bug or if there is an issue with my code.
armeria version: 1.29.3

import com.linecorp.armeria.client.ClientFactory;
import com.linecorp.armeria.client.Endpoint;
import com.linecorp.armeria.client.WebClient;
import com.linecorp.armeria.client.endpoint.EndpointGroup;
import com.linecorp.armeria.client.endpoint.healthcheck.HealthCheckedEndpointGroup;
import com.linecorp.armeria.client.endpoint.healthcheck.HealthCheckedEndpointGroupBuilder;
import com.linecorp.armeria.common.AggregatedHttpResponse;
import com.linecorp.armeria.common.HttpMethod;
import com.linecorp.armeria.common.HttpRequest;
import com.linecorp.armeria.common.SessionProtocol;
import com.linecorp.armeria.server.Server;
import com.linecorp.armeria.server.annotation.Get;
import com.linecorp.armeria.server.docs.DocService;

import java.nio.charset.StandardCharsets;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;

public class Main {
    public static void main(String[] args) {

        Server.builder()
            .http(8080)
            .annotatedService(new TestHandler())
            .serviceUnder("/docs", DocService.builder().build())
            .build()
            .start()
            .join();
    }

    static class TestHandler {

        WebClient client;

        TestHandler() {
            ClientFactory clientFactory = ClientFactory.builder()
                .useHttp2Preface(false)
                .workerGroup(200)
                .build();

            HealthCheckedEndpointGroupBuilder endpointGroupBuilder =
                // mock health fail.
                HealthCheckedEndpointGroup.builder(EndpointGroup.of(Endpoint.parse("localhost:8080")), "/healthxxxx")
                    .protocol(SessionProtocol.HTTP)
                    .useGet(true)
                    .clientFactory(clientFactory);
            client = WebClient
                .builder(SessionProtocol.HTTP, endpointGroupBuilder.build())
                .factory(clientFactory)
                .build();
        }


        @Get("/health")
        public String health() {
            return "ok";
        }

        @Get("/test1")
        public String test1() throws ExecutionException, InterruptedException {

            CompletableFuture<AggregatedHttpResponse> aggregate = client.execute(HttpRequest.of(HttpMethod.GET, "/test2"))
                .aggregate();
            CompletableFuture<String> future = aggregate
                .thenApply(res -> {
                    String data = res.content(StandardCharsets.UTF_8);
                    System.out.println(data);
                    return data;
                });
            future.whenComplete((res, ex) -> System.out.println(res));
            future.get();
            return "test1";
        }

        @Get("/test2")
        public String test2() {
            return "test2";
        }
    }
}

[ikhoon]

Armeria services are executed in an event loop which should not be blocked by a blocking operation such as future.get().

future.whenComplete((res, ex) -> System.out.println(res));
future.get();

You may want to annotate your service with @Blocking to make it work.

[lw33]

Thanks for answering.