Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not to use Http{Response,Status}Exception internally #4117

Merged
merged 4 commits into from
Mar 22, 2022

Commits on Feb 25, 2022

  1. Fix not to use Http{Response,Status}Exception internally

    Motivation:
    
    An `HttpResponseException` has an `HttpResponse`. So the default
    `ServerErrorHandler` extracts the `HttpResponse` from the exception.
    As the response is wrapped by `HttpResponseException`,
    decorators can not access the `HttpObject`s of the response in the
    exception.
    
    Users may find it hard to mutate the thrown `HttpResponse` because
    recovery should be done first. So it would be better not to use
    `HttpResponseException` or recover it before passing a response to
    decorators.
    
    Modifications:
    
    - Add `HttpFile.ofRedirect(location)` to indicate a file in a different
      location.
    - Recover an `Http{Response,Status}Exception thrown by
      `HealthCheckUpdateHandler`
    - Update Javadoc in detail for `Http{Response,Status}Exception`
    - Correctly propagate the cause of `Http{Response,Status}Exception` in
      `THttpService`
    
    Result:
    
    - You can now mutate a redirect response from `FileService` using
      `mapHeaders`
    - You no longer see an `HttpResponseException` or
      an `HttpStatusException` from built-in services.
    - Fixes line#4056
    ikhoon committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    89004da View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Peel exception

    ikhoon committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    4599cfd View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Address comments by @jrhee17

    ikhoon committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    2c1c181 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Address comments

    ikhoon committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    353c02d View commit details
    Browse the repository at this point in the history