Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DefaultCpuHealthChecker #4673
Added DefaultCpuHealthChecker #4673
Changes from 28 commits
f08cb8b
08c706e
551263a
afd1843
5e5069e
e4132b4
35da7bc
a0c04bb
dd68de9
8934066
32fd4f7
0a0f815
3b1770b
c8c1664
eda64c4
a4733f9
8be0675
07c4f02
d5f162f
760496c
a1df8fa
3f4a5fc
0b14883
667a0bf
2dae89c
9d7cd92
69df576
8f2b4a1
f6ef458
a766919
f469ac7
fad1155
29048d3
20e3188
5535d6a
759763b
fb59ec4
d1a06e3
1dda317
828e51a
d619208
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add validation on the values of
cpuUsageThreshold
andprocessCpuLoadThreshold
?It seems like the acceptable range is [0.0,1.0]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method won't be exposed because
CpuHealthChecker
isn't public.@line/dx What do you think of moving this API to the
HealthChecker
interface for better exposure?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrhee17 If I make this change, it will cause modifications to other files that implement this interface.
I think it would be better to address this in a new issue. If you have any other ideas, please let me know 🙂