Reorganize Vue templates #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have all the templates for Vue components well organized, we are going to move all of them inside a vue folder. The first one we have moved is the template for the silence form.
Instead of defining the whole template for the bootstrap-panel component as a string, which is more error prone, difficult to maintain and impossible to lint, we are now using a separate html file for it which solves those three problems.
Using different delimiters in different components can be error prone and confusing. Is better to stick to one kind of delimiters and use it always, for the previous reasons and also for consistency.
Instead of defining the whole template for the exporter-result component as a string, which is more error prone, difficult to maintain and impossible to lint, we are now using a separate html file for it which solves those three problems.
Using different delimiters in different components can be error prone and confusing. Is better to stick to one kind of delimiters and use it always, for the previous reasons and also for consistency.
Instead of defining the whole template for the exporter-test component as a string, which is more error prone, difficult to maintain and impossible to lint, we are now using a separate html file for it which solves those three problems.
Using different delimiters in different components can be error prone and confusing. Is better to stick to one kind of delimiters and use it always, for the previous reasons and also for consistency.
Instead of defining the whole template for the promql-query component as a string, which is more error prone, difficult to maintain and impossible to lint, we are now using a separate html file for it which solves those three problems.
Using different delimiters in different components can be error prone and confusing. Is better to stick to one kind of delimiters and use it always, for the previous reasons and also for consistency.
vincent-olivert-riera
changed the title
kfdm
approved these changes
Oct 30, 2023
No, this PR is ready to be merged as it is. Thanks! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the templates of all our Vue components as separate HTML files rather than JavaScript string variables, so they are:
Also, place all those templates inside a
vuefolder so it becomes clear they belong to Vue components.This PR will make the future PR for migrating to Vue 3 much shorter.