Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imagePullSecrets to the multicluster chart. #11287

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Add imagePullSecrets to the multicluster chart. #11287

merged 4 commits into from
Oct 4, 2023

Conversation

lhaussknecht
Copy link
Contributor

Fixes #11285

@lhaussknecht
Add imagePullSecrets to the multicluster chart.
e9553be 
Fixes linkerd#11285

Signed-off-by: Louis Haußknecht <lh@haussknecht.com>
@lhaussknecht lhaussknecht requested a review from a team as a code owner August 24, 2023 14:58
@lhaussknecht lhaussknecht mentioned this pull request Sep 1, 2023
Closed
@lhaussknecht
Add readme for imagePullSecrets
850f577 
Signed-off-by: Louis Haußknecht <lh@haussknecht.com>
adleong
adleong reviewed Sep 9, 2023
View reviewed changes
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the gateway and/or ServiceMirror need imagePullSecrets also?

@lhaussknecht
Add image-pull-secrets to gateway service account
d704dde 
Signed-off-by: Louis Haußknecht <lh@haussknecht.com>
@lhaussknecht
Copy link
Contributor Author

@adleong Added the secret also to the gateway service account.

@adleong
Copy link
Member

adleong commented Sep 28, 2023

thanks, @lhaussknecht! This looks great but it's probably not complete until we have image pull secrets for the service mirror controller too, right? Anyone who wants to use the linkerd-multicluster extension in an air gapped environment like this would need image pull secrets for the service mirror controller.

The service mirror controller is in the linkerd-multicluster-link helm chart. This isn't a helm chart we publish. Instead, the linkerd multicluster link command uses Helm as a library to render the linkerd-mutlicluster-link chart, which produces the service mirror controller (and related) manifests. Therefore, to add image pull secrets to the service mirror controller, we would also need to add an image pull secret helm value to the linkerd-multicluster-link chart and render it in the service mirror controller template.

@lhaussknecht
Add image-pull-secrets to linkerd-service-mirror account
d70fb1d 
Signed-off-by: Louis Haußknecht <lh@haussknecht.com>
@lhaussknecht
Copy link
Contributor Author

Thanks for the clarification. I added imagePull secrets to the service mirror.

adleong
adleong approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for this, @lhaussknecht

@adleong adleong merged commit cee2855 into linkerd:main Oct 4, 2023
6 checks passed
olix0r pushed a commit that referenced this pull request Dec 6, 2023
@lhaussknecht @olix0r
Add imagePullSecrets to the multicluster chart. (#11287)
0a72f1f 
Fixes #11285

Add an imagePullSecrets value to the linkerd-multicluster and linkerd-multicluster-link charts so that imagePullSecrets can be specified for the multicluster extension.

---------

Signed-off-by: Louis Haußknecht <lh@haussknecht.com>
olix0r added a commit that referenced this pull request Dec 6, 2023
@olix0r
v2.14.6
4669264 
* 6a07e2c Add ability to configure client-go's `QPS` and `Burst` settings (#11644)
* 64bccd9 Improve klog (client-go logs) handling (#11632)
* 284d76b service-mirror: support gateway resolving to multiple addresses (#11499)
* 0a72f1f Add imagePullSecrets to the multicluster chart. (#11287)
@olix0r olix0r mentioned this pull request Dec 6, 2023
Merged
olix0r added a commit that referenced this pull request Dec 7, 2023
@olix0r
stable-2.14.6
75fb714 
* 0a72f1f Add imagePullSecrets to the multicluster chart. (#11287)
* 284d76b service-mirror: support gateway resolving to multiple addresses (#11499)
* 64bccd9 Improve klog (client-go logs) handling (#11632)
* 6a07e2c Add ability to configure client-go's `QPS` and `Burst` settings (#11644)
* e294c78 Bump prometheus to v2.48.0 (#11633)
* b24b0e97c stable-2.14.6
olix0r added a commit that referenced this pull request Dec 7, 2023
@olix0r
stable-2.14.6
9893216 
* 0a72f1f Add imagePullSecrets to the multicluster chart. (#11287)
* 284d76b service-mirror: support gateway resolving to multiple addresses (#11499)
* 64bccd9 Improve klog (client-go logs) handling (#11632)
* 6a07e2c Add ability to configure client-go's `QPS` and `Burst` settings (#11644)
* e294c78 Bump prometheus to v2.48.0 (#11633)
* b24b0e97c stable-2.14.6
olix0r added a commit that referenced this pull request Dec 7, 2023
@olix0r
Merge pull request #11707 from linkerd/ver/stable-2.14.6
11b5ab8 
stable-2.14.6

* 0a72f1f Add imagePullSecrets to the multicluster chart. (#11287)
* 284d76b service-mirror: support gateway resolving to multiple addresses (#11499)
* 64bccd9 Improve klog (client-go logs) handling (#11632)
* 6a07e2c Add ability to configure client-go's `QPS` and `Burst` settings (#11644)
* e294c78 Bump prometheus to v2.48.0 (#11633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olix0r olix0r olix0r approved these changes

@adleong adleong adleong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to install linkerd-multicluster with helm in air-gapped environment
3 participants
@lhaussknecht @adleong @olix0r