Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timeout flag to multicluster check command #11420

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

moki1202
Copy link
Contributor

@moki1202 moki1202 commented Sep 26, 2023

Fixes #11266

Signed-off-by: Shashank shashanksingh819@gmail.com

Signed-off-by: Shashank <shashanksingh819@gmail.com>
@moki1202 moki1202 requested a review from a team as a code owner September 26, 2023 08:17
@moki1202
Copy link
Contributor Author

I'm not sure about the exact default duration for the timeouts so please let me know and I'll make the changes.

@olix0r olix0r self-requested a review September 26, 2023 14:56
@olix0r olix0r self-assigned this Sep 26, 2023
multicluster/cmd/check.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@olix0r olix0r merged commit cbaff7b into linkerd:main Sep 29, 2023
35 checks passed
olix0r added a commit that referenced this pull request Sep 29, 2023
This edge release makes Linkerd even better.

* Added a controlPlaneVersion override to the `linkerd-control-plane` Helm chart
  to support including SHA256 image digests in Linkerd manifests (thanks
  @cromulentbanana!) ([#11406])
* Improved `linkerd viz check` to attempt to validate that the Prometheus scrape
  interval will work well with the CLI and Web query parameters ([#11376])
* Improved CLI error handling to print differentiated error information when
  versioncheck.linkerd.io cannot be resolved (thanks @dtaskai) ([#11377])
* Fixed an issue where the destination controller would not update pod metadata
  for profile resolutions for a pod accessed via the host network (e.g.
  HostPort endpoints) ([#11334]).
* Added a validating webhook config for httproutes.gateway.networking.k8s.io
  resources (thanks @mikutas!) ([#11150])
* Introduced a new `multicluster check --timeout` flag to limit the time
  allowed for Kubernetes API calls (thanks @moki1202) ([#11420])

[#11150]: #11150
[#11334]: #11334
[#11376]: #11376
[#11377]: #11377
[#11406]: #11406
[#11420]: #11420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value of --wait flag is being used as a timeout by linkerd multicluster check command
4 participants