Fix cmemcahe_hash 0 values being translated to 1 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is a good catch, thanks for the patch. That "or 1" dates back to 2009 when that code was originally imported. I can't see that this patch is a problem, but I also can't confirm (or disconfirm) the need for the "or 1". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some keys which should be hashed to 0 end up being hashed to 1 in
cmemcache_hash. This results in a discrepancy between the server hash chosen by python-memcached and pylibmc (and other libmemcached derivatives).Remove the
or 1that causes this.An example of a key that is hashed to 0 by libmemcached using crc32+modula is
ob.