-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: downgrade srtool image compatible with polkadotv0.9.39 #1858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There might be multiple places where srtool is used (IIRC)
Hey @Kailai-Wang |
Next one would be |
So |
Yes let's wait a bit till 0.9.42 is done and re-test the compatibility with variant srtool version :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to merge it first. After 0.9.42 is done, update the tools again.
So based on the above: |
Resolves #1819
The issue as correctly identified by @Kailai-Wang was due to the low version of polkadot being used. We can in the future refer to the release notes of Polkadot which mention against which version of
srtools
andrustc
version it was tested against to build thewasm
.I've tested the fix on my fork here