Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade srtool image compatible with polkadotv0.9.39 #1858

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

felixfaisal
Copy link
Member

Resolves #1819

The issue as correctly identified by @Kailai-Wang was due to the low version of polkadot being used. We can in the future refer to the release notes of Polkadot which mention against which version of srtools and rustc version it was tested against to build the wasm.

I've tested the fix on my fork here

@felixfaisal felixfaisal requested review from Kailai-Wang and a team July 7, 2023 11:02
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There might be multiple places where srtool is used (IIRC)

@felixfaisal
Copy link
Member Author

Hey @Kailai-Wang
Not sure with which polkadot version we will be releasing the litentry parachain runtime, if with 9.39 then I can downgrade everywhere it is being used atleast in GitHub Actions.

@Kailai-Wang
Copy link
Collaborator

Hey @Kailai-Wang Not sure with which polkadot version we will be releasing the litentry parachain runtime, if with 9.39 then I can downgrade everywhere it is being used atleast in GitHub Actions.

Next one would be 0.9.42 I believe

@felixfaisal
Copy link
Member Author

So polkadotv0.9.42 is tested against rustc 1.69.0 as mentioned in the release notes. So should I wait until PRs for updating versions are merged and then update the srtools image or focus only on 0.9.39 for now and downgrade it. Let me know what you think.

@Kailai-Wang
Copy link
Collaborator

Yes let's wait a bit till 0.9.42 is done and re-test the compatibility with variant srtool version :)

Copy link
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to merge it first. After 0.9.42 is done, update the tools again.

@felixfaisal
Copy link
Member Author

So based on the above:
The srtools in the actions is being used in build_wasm and create_release_draft, I will not update create_release_draft as it makes no sense if we are planning on the next release to use 0.9.42. I think build_wasm is more important as of now, I'm assuming it will be used to perform runtime upgrades for the current parachain. Therefore I will merge this PR. Thanks!

@felixfaisal felixfaisal merged commit e4f804b into dev Jul 12, 2023
29 checks passed
@felixfaisal felixfaisal deleted the 1819-fx-srtools branch July 12, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building wasm with srtool fails
3 participants