Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add support for Ruby 2.4+ #1371

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Re-add support for Ruby 2.4+ #1371

merged 1 commit into from
Jan 6, 2022

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Jan 6, 2022

Description

Re-add support for Ruby 2.4+
Fixes #1369

@iMacTia iMacTia self-assigned this Jan 6, 2022
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iMacTia
Copy link
Member Author

iMacTia commented Jan 6, 2022

Will need to re-release faraday-multipart and faraday-retry to support Ruby 2.4+ or Ruby 2.5+, but I'll leave this for later as it's not as urgent

@Justin-W
Copy link

Justin-W commented Jan 6, 2022

Will need to re-release faraday-multipart and faraday-retry to support Ruby 2.4+ or Ruby 2.5+, but I'll leave this for later as it's not as urgent

@iMacTia The removal of support for Ruby v2.4 from faraday-retry is currently breaking some of our automation. We'd like to see that regression fixed ASAP.

@iMacTia iMacTia merged commit ef0040f into 1.x Jan 6, 2022
@iMacTia iMacTia deleted the eol-ruby-support branch January 6, 2022 21:45
@ccdredzik
Copy link

@iMacTia It is interesting that some do update their faraday library, but can't do so for the ruby version they're running. 2.4 is dead, so is 2.5. Don't resurrect them.

@iMacTia
Copy link
Member Author

iMacTia commented Jan 7, 2022

I'd normally agree but since I messed up a bit with the releases yesterday and that it didn't cost me much in the end, I re-added both in a fix release for 1.9.

That said, Faraday 2.0 will not support anything below 2.6 and we will drop EOL'ed support, even on minor version bumps, if it becomes a problem to support them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants