Handle verify hostname ssl option #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had been introduced in CRuby's openssl v2.0.0. And it has been bundled since CRuby 2.4. ref: https://docs.ruby-lang.org/en/2.4.0/NEWS.html Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com> Refer verify_hostname on net/http adapter But this option is just handled in Ruby master for now: ruby/ruby@be6931f Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com> Prevent false-positive assertion Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com> Handle verify_hostname in excon adapter on SSL context Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
|
@kazarin I took a quick look and the code changes seem good. |
|
Done. As suggested in rubocop warning I am using now Gemspec/DeprecatedAttributeAssignment cop |
|
That's even better! I didn't think it would have passed 😄 I'll have a final look |
iMacTia
approved these changes
Jun 30, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
This is rebased version of #1172. Next part will be in net_http adapter
Todos
List any remaining work that needs to be done, i.e:
Additional Notes
Optional section