Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bundler config to dependabot #1548

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

geemus
Copy link
Contributor

@geemus geemus commented Jan 14, 2024

Description

I was working on config for faraday-excon and when updating it's dependabot stuff I saw you all didn't have bundler configured here either, so I thought I would offer the setup in case you want it.

@olleolleolle
Copy link
Member

In case there's no Gemfile.lock, the dependabot Bundler update, does that really do anything?

@geemus
Copy link
Contributor Author

geemus commented Jan 14, 2024

@olleolleolle Great question.

With a Gemfile.lock it would be much more active (since it would tend to notify any time any version changed), but I believe it will still monitor and mention the dependencies in the Gemfile and gemspec if they should change. Depending on how tight those are, it may not come up often, but would be likely for major version bumps. I believe it also would monitor the dependency graph in the Gemfile/gemspec for any security issues that might arise, which might be more frequent.

I struggled to find clear documentation on this, but as an example if you look at the excon/excon (which also doesn't have a Gemfile.lock) dependency graph insights page it shows that it is monitoring the Gemfile (clicking the triple dots also shows that it is monitoring the gemspec): https://github.com/excon/excon/network/updates

Does that help/clarify?

@olleolleolle
Copy link
Member

It won't hurt, and it won't be many PRs anyway. Go ahead, please!

@olleolleolle
Copy link
Member

And, if we don't enjoy it, we can disable it and put a documenting comment in the YAML file and go on.

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a whirl!

@olleolleolle olleolleolle merged commit d820a58 into lostisland:main Jan 15, 2024
7 checks passed
@geemus geemus deleted the bundler-dependabot-config branch January 15, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants