Ability to run Antimine into Android Automotive #445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks for your contribution! |
lucasnlm
reviewed
May 12, 2023
| android:resource="@xml/file_paths" /> | ||
| </provider> | ||
| <meta-data android:name="com.android.automotive" | ||
| android:resource="@xml/automotive_app_desc"/> |
There was a problem hiding this comment.
Maybe we can use the same AndroidManifest from app and add this new automotive module only with these new params. Like it's done with intant module and create a new flavor adding this flavor: adding googleAutomotive and including this module with googleAutomotiveImplementation project(':automotive')
lucasnlm
reviewed
May 12, 2023
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <automotiveApp> | |||
| <uses name="video"/> | |||
There was a problem hiding this comment.
I'm not sure, but I think we should add <uses name="media"/> too.
|
@googlvalenzuela Added some suggestions. I will read the Auto docs to get more info too. |
|
@googlvalenzuela Thanks for you contribution! I will implement automotive support in #485. So I will close this PR and implement the changes there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucas:
Did a small change in order to allow your game to be able to be pushed to android automotive that requires minor changes (manifest).
Would you mind taking a look and give me anyfeedback on this change