Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alarm clock links #833

Merged

Conversation

ndsvw
Copy link
Contributor

@ndsvw ndsvw commented Sep 16, 2024

Project was moved, as described here: https://launchpad.net/alarm-clock

Summary by Sourcery

Update the Alarm Clock project links in the README files across different languages to point to the new GitHub repository and website.

Enhancements:

  • Update links for the Alarm Clock project in multiple language versions of the README to reflect the new GitHub repository and website.

Copy link
Contributor

sourcery-ai bot commented Sep 16, 2024

Reviewer's Guide by Sourcery

This pull request updates the links for the Alarm Clock application across multiple README files in different languages. The changes reflect the project's move from Launchpad to GitHub, updating both the source code repository link and the project's website URL.

File-Level Changes

Change Details Files
Update Alarm Clock application links
  • Change source code repository link from Launchpad to GitHub
  • Update project website URL
  • Modify the order of the URL and description in some files for consistency
README.md
README_es-ES.md
README_fr-FR.md
README_pt-BR.md
README_th-TH.md
README_zh-CN.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ndsvw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding more context to the PR description about why the Alarm Clock project links needed to be updated. This can help future contributors understand the reasoning behind these changes.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link
Owner

@luong-komorebi luong-komorebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for updating the link

@luong-komorebi luong-komorebi merged commit 59fd3e7 into luong-komorebi:master Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants