Replace calls to Fd() with syscall.RawConn.Control() #371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fd()
removes theO_NONBLOCK
flag from the descriptor before returning it.From os/file_unix.go:
When
Fd()
is called on a*os.File
obtained viaconn.File()
, this descriptor is actually a duplicate but the underlying socket is shared. The end result is that the originalconn
still thinks it has a non-blocking socket, while the socket actually became blocking. This causes things likeconn.Close()
blocking forever if no data is received.This should actually resolve #361 .
This change is