fix(ndt7-protocol): acknowledge the importance of TCP_INFO #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassosimone
changed the title
With @robertodauria, we updated the spec to clarify what we originally meant for ndt7 (i.e., only using application-level measurements is possible) and what it actually happened (i.e., we discovered that without TCP_INFO at the server we cannot write radically simple clients, which was also a ndt7 design goal).
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 0 of 1 approvals obtained (waiting on @bassosimone and @stephen-soltesz)
spec/ndt7-protocol.md line 44 at r2 (raw file):
ndt7 includes goodput measurements as well as `TCP_INFO` measurements collected by the server. This implementation choice allows for maximually simpler clients and pushes the complexity to the server.
Typo: maximally
|
Fixed |
There was a problem hiding this comment.
Reviewable status: 0 of 1 approvals obtained (waiting on @bassosimone)
spec/ndt7-protocol.md line 42 at r3 (raw file):
the application level, without including the overhead of WebSocket, TLS, TCP/IP, and link layer headers). However, the M-Lab deployment of ndt7 includes goodput measurements as well as `TCP_INFO` measurements
I don't understand "However, the M-Lab deployment of ndt7 includes goodput measurements as well as TCP_INFO measurements collected by the server." Where are the goodput measurements today?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @robertodauria, we updated the spec to clarify what we originally meant for ndt7 (i.e., only using application-level measurements is possible) and what it actually happened (i.e., we discovered that without TCP_INFO at the server we cannot write radically simple clients, which was also a ndt7 design goal).
This change is