Fix: deterministic check for FlowDeleted #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinaleonr
approved these changes
Nov 7, 2023
complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test implementation was flaky. This change uses a channel to signal that the
FlowDeletedpath has been reached.While the
srv.Close()will prevent new connections, and thedownloadHelper()closes the client connection, there is still an independent handler goroutine that reaches theFlowDeletedpath after a short delay. Rather than using a larger static delay, this change sets a maximum delay and waits for thedeletedchannel to close, allowing the test to stop as quickly as it's able to.This change is