Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flagx.StringFile for autocert.hostname and token.machine #406

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Sep 27, 2024

This change updates the flag type used by the -autocert.hostname and -token.machine flags to flagx.StringFile. This flag type allows a single flag to pass a literal string value, e.g. the actual hostname, or a filename with the contents for the string value, e.g. the hostname in a file.

This change is in service of enabling access token verification in autonode deployments. Current users of autocert.hostname will need to be updated with a prefix of @ to read from the named file. The only known users are from https://github.com/m-lab/autonode


This change is Reviewable

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 1df5867 into main Sep 30, 2024
5 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-stringfile-flags branch September 30, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants