Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ITestContext hook #407

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add ITestContext hook #407

wants to merge 9 commits into from

Conversation

mikeblakeuk
Copy link
Contributor

Add hook in the same style as AssemblyContext

(PR Used to run unit tests!)

@mikeblakeuk
Copy link
Contributor Author

Hi @robertcoltheart,
Hope you are handling the current quarantine ok.
Not sure what your thoughts are on adding a ITestContext to allow users to add hooks when tests start and stop?
It's super hard to time the tests. Only the It is measured when using the VSAdapter. We are going use AppInsights to track the test times.

@robertcoltheart
Copy link
Member

Sorry for the delay. I get where you're going with this, but I think it needs a bit of thought. For instance, your implementation only looks in the current assembly for a test context. What if you are timing tests for multiple test projects or multiple repos? It implies a lot of copy+paste code.

The approach Xunit takes is to have assembly attributes that load the extensions into the xunit engine. That's obviously quite a bit of work.

Will noodle a bit more on this topic and see if I can think of something that will help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants