Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF view rendering is hanging #38

Closed
serhii-petrenko opened this issue Jun 30, 2024 · 2 comments · Fixed by #40
Closed

PDF view rendering is hanging #38

serhii-petrenko opened this issue Jun 30, 2024 · 2 comments · Fixed by #40
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@serhii-petrenko
Copy link

Hi!
Thanks a lot for all your efforts and the amazing theme!

Material theme enable

m1

Material theme disabled

2 screenshots to show all network calls
No. 1
m2
No. 2
m3

Configurations
OJS version 3.4.0.5
PHP version 8.3.8
PDF.JS PDF Viewer https://github.com/pkp/pdfJsViewer/tree/stable-3_4_0

@madi-nuralin
Copy link
Owner

madi-nuralin commented Jun 30, 2024

Hi!
Thank you for reporting the issue.
Recently I switched to TailwindCSS framework, and for now it's quite challenging to integrate stylesheet which is provided by another plugin.
I'm planning to overwrite pdfJsViewer's stylesheet or try to apply default style if possible.

@madi-nuralin madi-nuralin reopened this Jun 30, 2024
@madi-nuralin madi-nuralin added this to the v3_0_1-0 milestone Jun 30, 2024
@madi-nuralin madi-nuralin added the enhancement New feature or request label Jun 30, 2024
@madi-nuralin madi-nuralin self-assigned this Jun 30, 2024
madi-nuralin added a commit that referenced this issue Jul 1, 2024
@madi-nuralin
Copy link
Owner

The reason of pdf viewer fault is that material theme comes without jquery lib.
As a result, the jquery will be included only when previewing pdf.

image

@madi-nuralin madi-nuralin linked a pull request Jul 1, 2024 that will close this issue
madi-nuralin added a commit that referenced this issue Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants