Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin notice improvements. #174

Merged

Conversation

oleksandr-mykhailenko
Copy link
Collaborator

Small code cleanup

Small code cleanup
@oleksandr-mykhailenko oleksandr-mykhailenko merged commit 77dcd63 into master Feb 25, 2024
@oleksandr-mykhailenko oleksandr-mykhailenko deleted the DE-1244-notice-is-not-dismissable-wp-mailgun branch February 25, 2024 12:14
@midweste
Copy link

https://github.com/mailgun/wordpress-plugin/pull/174/files#diff-35327cdcf196c01a80be6f8a02b58f139b1e12c01bdad9aa86a4b1a3c63484f7R340

Missing check if session exists is causing warning

Warning: Undefined global variable $_SESSION in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340 Warning: Trying to access array offset on value of type null in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340

@oleksandr-mykhailenko
Copy link
Collaborator Author

https://github.com/mailgun/wordpress-plugin/pull/174/files#diff-35327cdcf196c01a80be6f8a02b58f139b1e12c01bdad9aa86a4b1a3c63484f7R340

Missing check if session exists is causing warning

Warning: Undefined global variable $_SESSION in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340 Warning: Trying to access array offset on value of type null in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340

Gotcha, thank you for that

@midweste
Copy link

https://github.com/mailgun/wordpress-plugin/pull/174/files#diff-35327cdcf196c01a80be6f8a02b58f139b1e12c01bdad9aa86a4b1a3c63484f7R340
Missing check if session exists is causing warning
Warning: Undefined global variable $_SESSION in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340 Warning: Trying to access array offset on value of type null in /app/web/wp-content/plugins/mailgun/includes/admin.php on line 340

Gotcha, thank you for that

thank you! I'm sorry I don't have the time at the moment to put in a pull request.

@midweste
Copy link

Just got the most recent version, thank you so much for adding the check. Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants