fixed stable_sort and sort order #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rduino) They lack the defines from funcf to func. This adds checks, temporarily defines, then undefines at the end.
Revealed on platforms like AVR where float math functions are just defines pointing to the double math functions, which caused an infinite (recursive) loop.
|
Thanks for this. I'm leaving this open for the moment, as it is a big change, and will take a bit more review. |
|
Sure, take your time 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! thank you for this library! i found a little issue with the ordering of functions in algorithm. here is the fixed version, merge it if you like it.